i have
elite 2 og black - use daily on my xbox series X, i drop this fucker all the time by accident (~4 feet) and the thumbs/d-pad flies off (magnetic) but its still trucking just fine, honestly shocking its not all fucked up. i previously had two elite 1s and both got wonky with the grips peeling off after 2 years or so. I rarely use my back paddles
elite 2 white (cheaper) - paired to PC via bluetooth, used a few times a month. finished lies of P with it, no issues. rarely use back paddles. Xbox controllers work better with PC imo because most games only show xbox layout buttons and i don't need to run any extra software shit to make it all work. I have zero issues switching between ps5/xbox controllers. Oh, this works perfectly fine in Yuzu/Ryujinx to run switch games, played a bit of Mario Wonder yesterday no issues and back paddles are nice in switch games, remap them to whatever you want.
scuf FPS Pro Ps5 - have had it for a year now, only use it for specific games that back paddle helps a lot with. No real issues, battery life kinda sucks but its at least 5 hours and I almost never game that long. I bought it for Elden Ring and loved it, it let me horse mount easily while still attacking and moving. Good for COD too, reload while aiming/moving/sprinting.
regular dual sense - my go to controller, use it daily on ps5.
switch pro - on my switch, but i haven't turned on my switch in like six months.
My brother has the new Sony DualSense edge, Sonys version of the xbox elite, and he says its great except the battery life apparently blows, 3-4 hours compared to 5-6 hours for dualsense. Makes sense, its basically just a mod'd dualsense.
I always try to keep it simple, the more weird your connections are - extra bluetooth controllers, weird adapters etc - the more work you just seem to be doing. A good new PC should have great bluetooth built in, if it doesn't... its not a great PC. The only huge difference I've really noticed in controllers is back paddles, and you have to find ones that feel good. I like the elite 2s and SCUFs, when I tried some of the shitty $20 "attach your own" type they always feel awful.
For controllers I use a LOT I buy them at gamestop and get a 2 year warranty and put in my google calender a reminder 18 months out to go in with the box, receipt, controller, and swap. I just say it has stick drift and bad battery life and they just give me a new one, no questions asked. Done it 5+ years with my ps4/ps5 controllers every 2 years, a $20 tax to not care how I use em. I'll be sad when gamestop vanishes.