IT/Software career thread: Invert binary trees for dollars.

Noodleface

A Mod Real Quick
39,875
18,645
Does anyone here use AI for reviewing code?
clear conversation -> Review -> Fix or refute(and save to memory!) -> repeat
I've never been able to get it to converge, it always finds new shit. And later into that cycle, a significant chunk of the findings are code changes it made.
Not my own code, but I use it for other's PRs.

I basically point my agent at their branch and ask it to do a code review on it (and provide no context). I then look at what it recommends and verify for myself. Anything I think is worthy, I comment in the PR or ask questions about.

What I HATE is this guy on my team that does it and just copies and pastes the diarrhea Claude spits out (like 10 paragraphs worth) with no human interpretation behind it. Like I said, this is how old heads are using it. It's essentially useless and I always ignore it if people do that.
 
  • 1Like
Reactions: 1 user

Deathwing

<Bronze Donator>
17,801
8,759
Only hobby code, so maybe not too relevant, but I've been having one model orchestrate another to check and another to fix so they basically argue amongst themselves until the orchestrator is satisfied. They eventually sort it out, but it takes forever. Generally Fable to orchestrate and swapping between Sol/GLM to review/fix. I mostly did it that way to budget/spread tokens, and it works, but probably mostly because it takes so damned long.
That's definitely a "solution" and one my boss went to almost immediately. He's on the $200 Claude Code plan and was complaining about running out of tokens 5 days into his weekly session. I was lamenting having to ask for more(because I don't think we've solved the baggage that comes with AI) just to participate in whatever clown car of a workflow my boss is cooking up. Now I'm thinking I have more immediate counter points. Spending 90% of your feature in MR review is demoralizing.
 

Deathwing

<Bronze Donator>
17,801
8,759
Not my own code, but I use it for other's PRs.

I basically point my agent at their branch and ask it to do a code review on it (and provide no context). I then look at what it recommends and verify for myself. Anything I think is worthy, I comment in the PR or ask questions about.

What I HATE is this guy on my team that does it and just copies and pastes the diarrhea Claude spits out (like 10 paragraphs worth) with no human interpretation behind it. Like I said, this is how old heads are using it. It's essentially useless and I always ignore it if people do that.
Can you tell the difference if someone had already done an AI review on their code? If not, doesn't that imply you should review your own code similarly? If you can, do you toss the review away as it's potentially already into garbage territory?

I've definitely done what your teammate has done. Partly because it's easy and partly because my boss was doing it, so...I guess that's what we do now. Thanks for reminding me, I'm going to stop doing that, I like your methodology better.

Claude's verboseness has definitely been an issue on my team. Some people don't like how much reading it entails. If you don't put any leashes on it, the MR descriptions, commit messages, thread comments, and code comments can be gigantic.

Another problem is that it can seem insincere. During a team discussion on this topic, one of my MRs was used as an example. My boss started 9 threads, each at least 4 paragraphs long, took me all afternoon to respond and fix those threads. People thought the review was insincere because it was obviously written by AI. My boss said he spent 4 hours chatting with the AI before filing each thread.
WTF2.png
 
  • 1WTF
Reactions: 1 user

Sheriff Cad

scientia potentia est
<Nazi Janitors>
34,880
85,267
That's definitely a "solution" and one my boss went to almost immediately. He's on the $200 Claude Code plan and was complaining about running out of tokens 5 days into his weekly session. I was lamenting having to ask for more(because I don't think we've solved the baggage that comes with AI) just to participate in whatever clown car of a workflow my boss is cooking up. Now I'm thinking I have more immediate counter points. Spending 90% of your feature in MR review is demoralizing.
Haven't coded at all with AI but isn't this what the "agents" do in multi-agent plans? Grok used to have the multi-agent thing a few months ago with their $30 plan, but now they hid it behind the $100 plan. It would show the agents asking each other questions, giving each other tasks, checking on the results of this or that, and I thought that would be a really smart way to avoid some of the dumb AI pitfalls, have a supervisor model that asks other models questions and sanity-checks the answer. Whenever I draft a brief using AI, I always polish it up to where I'm ready to file, then run the whole thing again through a fresh conversation for final review, and it "often" finds little things that the other conversation didn't - same model, exact same brief.

Anyway, is the multi-agent thing doing anything like what we're talking about?