It doesn't split the trading playerbase though, one faction simply cannot trade at all but instead gets better droprate, which is basically SSF from PoE but with actual benefits for it. Anyone who wants to trade has to be in the trading faction, so there's effectively only one group of ppl for trading.
I think it's mostly fine although the trading faction probably could have some restrictions relaxed to be a little bit more open since that's the whole point, but personally since I don't really care about trading I'd just join the other faction and never have to worry about trading, while not being penalized for it as much due to having better droprate from the non trading faction(unlike poe where SSF is just worse and the game is balanced with trading in mind).