Weapon element doesn't do anything, other than fancy effects on kills with physical skills(but the damage is still converted to physical, or should be, might be bugs). Physical damage is however affected by the %dmg affix on weapons, so for the highest damage possible, a "black" weapon, which is...