Crafting is meh. At this point unless you're extremely dedicated, you won't catch up to high end crafting. On the other hand you can make money out of low end crafting in various ways. You could ignore the whole thing and make money otherwise though(daillies and spiritbinding). At the same time leveling the crafts now will save you time for the expansion.
The expansion is adding interesting stuff to crafting, but it's not really in need of fixing. Crafting is very alive and well at this point of the game, it's a money maker for both new players and long time crafters alike, though since it uses a progression system similar to raids and shit, it's very hard to catchup quickly, plus an accomplished crafter needs more or less every crafts leveled up so it's like a real investment, both in time and money to get there. There's alwyas a high demand in most stuff from crafters because they make housing furnitures and glamour items(cosmetics), as well as a bunch of gear to break down into materias for people who need to do their relics and what not, and for some slots, crafted gear is actually BiS or close enough to it, though it requires stupid amount of money to make the item then meld the materias in it(mostly the materias).
The only shit classes at the moment would be Alchemist and Cooking, since potions and food are more or less the same as they've always been and the side stuff they make isn't that good. Alchemy was good like last tier of content kinda with Putty, and they can make a few weapons and what not so there can be some money to be made, but Cooking is just dreadful. Then again, it sells quick, so it might be worth it if you don't mind afk crafting for hours with shitty profits per item. Main issue of cooking is the new food they kept adding is useless due to how food works in this game(it gives % of the stats with a cap, however the % are fucked up and basically no one can reach the caps, making the higher food useless when the old food gives the same benefits anyway).
